Change handling of invalid JSON and XML request body#177
Open
creepyghost wants to merge 1 commit intowaf_nginxfrom
Open
Change handling of invalid JSON and XML request body#177creepyghost wants to merge 1 commit intowaf_nginxfrom
creepyghost wants to merge 1 commit intowaf_nginxfrom
Conversation
### modsecurity.h * Standardize body parser return codes ### msc_json.c, msc_xml.c * Return special error code on body parsing failure ### msc_reqbody.c, apache2_io.c, mod_security2.c * Change body parsing error codes to refer to constants defined in header.
7f48e3a to
980561c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
and throws an
HTTP 500status. This behaviour isn't exactly compliant with the HTTP RFC.BODY_PARSER_ERR_INVALID_BODYnow indicates that the body parser failed.200002whichhandles the
REQBODY_ERRORtarget to return a block decision withHTTP 400.Changes
modsecurity.h
msc_json.c, msc_xml.c
msc_reqbody.c, apache2_io.c, mod_security2.c
defined in header.